Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Fix build and test #56

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Fix build and test #56

wants to merge 4 commits into from

Conversation

splushii
Copy link

Relates to #53

Using pyenv instead of local python + virtualenv for local testing, to improve reproducability. @svtfrida please let me know what you think about this approach, and test to see if it works locally on your end as well!

Bumping pip-tools was one issue found locally, that may help the Travis CI as well. Other than that, no work specifically with fixing the Travis CI yet.

@splushii
Use pyenv for local testing
165ed34 
Replace local python with virtualenv with pyenv for better
reproducability

Using python 3.7.1 as pyenv version to reflect latest supported python
tested by CI
@splushii
Bump pip-tools 3.6.1 -> 6.1.0
4b709f3 
To support newer pip versions
@splushii splushii mentioned this pull request Apr 24, 2021
Open
@ghost
Copy link

ghost commented Apr 27, 2021 •
edited by ghost
Loading

Everything works fine locally except the deployment tests, which fail due to the first $(shell make -s -C lxd orm-ip) evaluation returning an error. Using an already-running container everything works fine though, so probably to do with the timing. I've looked at the wait_for_orm.sh script as well but can't see anything wrong with it. If things work as expected for you it might be an issue with my local LXD.

I agree that moving to pyenv is a good idea, and have found no issues with the new environment.

@ghost ghost linked an issue Apr 28, 2021 that may be closed by this pull request
Build pipeline broken #53
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build pipeline broken
1 participant
@splushii