add jersey 2 to jaxrs generator #2263

DavidMarinCalleja · 2016-02-27T17:54:41Z

adding jersey 2 to Java server (jaxrs). Command line example:
generate -l jaxrs --library jersey2

wing328 · 2016-02-27T18:05:08Z

@David-Marin-Calleja thanks for the PR but the CI tests failed. Here is part of the result:

Tests run: 345, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 6.886 sec <<< FAILURE! - in TestSuite
annotationsTest(io.swagger.codegen.java.jaxrs.AllowableValuesTest)  Time elapsed: 0.011 sec  <<< FAILURE!
java.lang.NullPointerException: null
    at java.io.Reader.<init>(Reader.java:78)
    at java.io.InputStreamReader.<init>(InputStreamReader.java:113)
    at org.apache.commons.io.IOUtils.copy(IOUtils.java:1906)
    at org.apache.commons.io.IOUtils.toString(IOUtils.java:778)
    at io.swagger.codegen.java.jaxrs.AllowableValuesTest.loadClassResource(AllowableValuesTest.java:27)
    at io.swagger.codegen.java.jaxrs.AllowableValuesTest.annotationsTest(AllowableValuesTest.java:60)

annotationsTest(io.swagger.codegen.java.jaxrs.AllowableValuesTest)  Time elapsed: 0 sec  <<< FAILURE!
java.lang.NullPointerException: null
    at java.io.Reader.<init>(Reader.java:78)
    at java.io.InputStreamReader.<init>(InputStreamReader.java:113)
    at org.apache.commons.io.IOUtils.copy(IOUtils.java:1906)
    at org.apache.commons.io.IOUtils.toString(IOUtils.java:778)
    at io.swagger.codegen.java.jaxrs.AllowableValuesTest.loadClassResource(AllowableValuesTest.java:27)
    at io.swagger.codegen.java.jaxrs.AllowableValuesTest.annotationsTest(AllowableValuesTest.java:60)

annotationsTest(io.swagger.codegen.java.jaxrs.AllowableValuesTest)  Time elapsed: 0 sec  <<< FAILURE!
java.lang.NullPointerException: null
    at java.io.Reader.<init>(Reader.java:78)
    at java.io.InputStreamReader.<init>(InputStreamReader.java:113)
    at org.apache.commons.io.IOUtils.copy(IOUtils.java:1906)
    at org.apache.commons.io.IOUtils.toString(IOUtils.java:778)
    at io.swagger.codegen.java.jaxrs.AllowableValuesTest.loadClassResource(AllowableValuesTest.java:27)
    at io.swagger.codegen.java.jaxrs.AllowableValuesTest.annotationsTest(AllowableValuesTest.java:60)

annotationsTest(io.swagger.codegen.java.jaxrs.AllowableValuesTest)  Time elapsed: 0 sec  <<< FAILURE!
java.lang.NullPointerException: null
    at java.io.Reader.<init>(Reader.java:78)
    at java.io.InputStreamReader.<init>(InputStreamReader.java:113)
    at org.apache.commons.io.IOUtils.copy(IOUtils.java:1906)
    at org.apache.commons.io.IOUtils.toString(IOUtils.java:778)
    at io.swagger.codegen.java.jaxrs.AllowableValuesTest.loadClassResource(AllowableValuesTest.java:27)
    at io.swagger.codegen.java.jaxrs.AllowableValuesTest.annotationsTest(AllowableValuesTest.java:60)

annotationsTest(io.swagger.codegen.java.jaxrs.AllowableValuesTest)  Time elapsed: 0.001 sec  <<< FAILURE!
java.lang.NullPointerException: null
    at java.io.Reader.<init>(Reader.java:78)
    at java.io.InputStreamReader.<init>(InputStreamReader.java:113)
    at org.apache.commons.io.IOUtils.copy(IOUtils.java:1906)
    at org.apache.commons.io.IOUtils.toString(IOUtils.java:778)
    at io.swagger.codegen.java.jaxrs.AllowableValuesTest.loadClassResource(AllowableValuesTest.java:27)
    at io.swagger.codegen.java.jaxrs.AllowableValuesTest.annotationsTest(AllowableValuesTest.java:60)


Results :

Failed tests: 
io.swagger.codegen.java.jaxrs.AllowableValuesTest.annotationsTest(io.swagger.codegen.java.jaxrs.AllowableValuesTest)
  Run 1: AllowableValuesTest.annotationsTest:60->loadClassResource:27 Â» NullPointer
  Run 2: AllowableValuesTest.annotationsTest:60->loadClassResource:27 Â» NullPointer
  Run 3: AllowableValuesTest.annotationsTest:60->loadClassResource:27 Â» NullPointer
  Run 4: AllowableValuesTest.annotationsTest:60->loadClassResource:27 Â» NullPointer
  Run 5: AllowableValuesTest.annotationsTest:60->loadClassResource:27 Â» NullPointer


Tests run: 341, Failures: 1, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] swagger-codegen-project ........................... SUCCESS [3.156s]
[INFO] swagger-codegen (core library) .................... FAILURE [18.308s]
[INFO] swagger-codegen (executable) ...................... SKIPPED
[INFO] swagger-codegen (maven-plugin) .................... SKIPPED

You can run the test locally by mvn verify -Psamples

wing328 · 2016-03-07T15:06:09Z

I'll review this tomorrow and let you know if I've any questions. Thanks again for the contribution.

wing328 · 2016-03-08T14:41:49Z

I got the following when running ./bin/jaxrs-petstore-server.sh:

[main] WARN io.swagger.codegen.DefaultCodegen - Empty operationId found for path: get /pet/{petId}?testing_byte_array=true. Renamed to auto-generated operationId: petPetIdtesting_byte_arraytrueGet
[main] ERROR io.swagger.codegen.AbstractGenerator - JavaJaxRS/api.mustache (No such file or directory)
[main] ERROR io.swagger.codegen.AbstractGenerator - can't load template JavaJaxRS/api.mustache
Exception in thread "main" java.lang.RuntimeException: Could not generate api file for 'pet?testing_byte_array=true'
    at io.swagger.codegen.DefaultGenerator.generate(DefaultGenerator.java:373)
    at io.swagger.codegen.cmd.Generate.run(Generate.java:202)
    at io.swagger.codegen.SwaggerCodegen.main(SwaggerCodegen.java:36)
Caused by: java.lang.RuntimeException: can't load template JavaJaxRS/api.mustache
    at io.swagger.codegen.AbstractGenerator.readTemplate(AbstractGenerator.java:50)
    at io.swagger.codegen.DefaultGenerator.generate(DefaultGenerator.java:334)
    ... 2 more
swagger-codegen|master⚡ ⇒ ./bin/jaxrs-petstore-server.sh

Would you please take a look?

Can you also create ./bin/jaxrs-jersey2-petstore-server.sh using --library jersey2 and output the files under samples/server/petstore/jaxrs-jersey2?

fehguy · 2016-03-08T14:44:38Z

@wing328 I'm not sure how this got in:

https://github.com/swagger-api/swagger-codegen/blob/master/modules/swagger-codegen/src/test/resources/2_0/petstore.json#L22

But it's illegal by the Swagger Spec and may be confusing to people. Query parameters are not allowed in the path segment...

wing328 · 2016-03-09T01:49:48Z

@fehguy we added those (fake endpoints) internationally for unit testing.

Agree that query parameters should not be allowed in the path segment.

FYI. ./bin/jaxrs-cxf-petstore-server.sh does not show any error.

fehguy · 2016-03-09T21:59:40Z

Can we just remove that and replace it with a full path instead? Because it's illegal, people will see it and think it's OK. Actually codegen (via parser) should not allow it, so if I add that check in the parser, you'll start failing the build.

wing328 · 2016-03-10T00:16:10Z

Understood the side effect of putting that in Petstore. If using the full path, the endpoint won't work since we need to modify the Petstore server as well.

I might have missed it but do we have the source code of Petstore server available publicly?

(btw, other Java server stub generator does not throw errors for path with URL query string)

fehguy · 2016-03-10T03:55:28Z

The petstore source lives here:

https://github.com/swagger-api/swagger-samples/tree/docker/java/java-jaxrs

It doesn't matter if other generators work, it's simply illegal with the swagger definition to define the URL with a query string. They really shouldn't work.

wing328 · 2016-03-10T04:02:35Z

OK. We'll look into swagger-sample to add more proper test cases before removing the workaround.

wing328 · 2016-03-15T14:24:45Z

@David-Marin-Calleja I'd a look at the error message again and it seems like JavaJaxRS/api.mustache is missing

[main] ERROR io.swagger.codegen.AbstractGenerator - JavaJaxRS/api.mustache (No such file or directory)
[main] ERROR io.swagger.codegen.AbstractGenerator - can't load template JavaJaxRS/api.mustache

Is that accidentally removed as part of this PR?

swagger-codegen|master⚡ ⇒ ls modules/swagger-codegen/src/main/resources/JavaJaxRS/ | grep api
apiServiceFactory.mustache
swagger-codegen|master⚡ ⇒

DavidMarinCalleja · 2016-03-16T21:17:12Z

@wing328 I will look into it.

fehguy · 2016-04-05T06:09:44Z

This was handled in #2488.

DavidMarinCalleja added 8 commits February 26, 2016 18:54

Merge remote-tracking branch 'swagger-api/master'

ff8743f

pom.mustache for pom.xml with jersey 2.22

dcc4ff6

web.mustache for web.xml with jersey 2.22

7167889

new import statements to jersey 2.x

8173d64

move template files JavaJaxRS

f65f31b

clean pom y web files

efacc60

Merge remote-tracking branch 'swagger-api/master'

50151be

setup jersey 2.x template directory

13dd3ed

wing328 added the Enhancement: General label Feb 27, 2016

wing328 modified the milestones: Future, v2.1.6 Feb 27, 2016

wing328 added the Server: Java label Feb 27, 2016

Fixed test case file

b91fec8

wing328 mentioned this pull request Mar 2, 2016

swagger-codegen for server using jersey2 with jersey2 annotations #1554

Closed

wing328 modified the milestones: v2.2.0, v2.1.6 Mar 19, 2016

fehguy mentioned this pull request Apr 3, 2016

Add jersey2 server support #2488

Merged

fehguy closed this Apr 5, 2016

wing328 modified the milestones: v2.1.6, v2.2.0 Apr 5, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add jersey 2 to jaxrs generator #2263

add jersey 2 to jaxrs generator #2263

Uh oh!

DavidMarinCalleja commented Feb 27, 2016

Uh oh!

wing328 commented Feb 27, 2016

Uh oh!

wing328 commented Mar 7, 2016

Uh oh!

wing328 commented Mar 8, 2016

Uh oh!

fehguy commented Mar 8, 2016

Uh oh!

wing328 commented Mar 9, 2016

Uh oh!

fehguy commented Mar 9, 2016

Uh oh!

wing328 commented Mar 10, 2016

Uh oh!

fehguy commented Mar 10, 2016

Uh oh!

wing328 commented Mar 10, 2016

Uh oh!

wing328 commented Mar 15, 2016

Uh oh!

DavidMarinCalleja commented Mar 16, 2016

Uh oh!

fehguy commented Apr 5, 2016

Uh oh!

Uh oh!

add jersey 2 to jaxrs generator #2263

add jersey 2 to jaxrs generator #2263

Uh oh!

Conversation

DavidMarinCalleja commented Feb 27, 2016

Uh oh!

wing328 commented Feb 27, 2016

Uh oh!

wing328 commented Mar 7, 2016

Uh oh!

wing328 commented Mar 8, 2016

Uh oh!

fehguy commented Mar 8, 2016

Uh oh!

wing328 commented Mar 9, 2016

Uh oh!

fehguy commented Mar 9, 2016

Uh oh!

wing328 commented Mar 10, 2016

Uh oh!

fehguy commented Mar 10, 2016

Uh oh!

wing328 commented Mar 10, 2016

Uh oh!

wing328 commented Mar 15, 2016

Uh oh!

DavidMarinCalleja commented Mar 16, 2016

Uh oh!

fehguy commented Apr 5, 2016

Uh oh!

Uh oh!