Can't run ./bin/scala-petstore.sh as instructed at README #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cala 2.9.1, but that is broken because BeanProperty moved, so instead use 2.10 as the default but add the option of using Scala 2.11
This was referenced Oct 8, 2014
Closed
fehguy
added a commit
that referenced
this pull request
Dec 24, 2014
Can't run ./bin/scala-petstore.sh as instructed at README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instructions do not work, because the default is to use Scala 2.9.1 but BeanProperty moved - see #208 and # 233
Switch the default to use 2.10.3, which does work, add a 2.11 target (which works too), and fix the client test, which was broken because Tag is ambiguous. I left the 2.9.1 profile in, but arguably it could be removed.
This fix does mean it works out the box, which is helpful :)
The test code is not being autogenerated, right? I couldn't find any template.
Fixes #208 and #233