Skip to content

Conversation

jgavris
Copy link
Contributor

@jgavris jgavris commented Jun 30, 2016

  • Also fix up missing rawValue in Enum parameter generation for formParams.

I tried running ./bin/swift-petstore.sh but it appears that is also broken on master. A potential solution to uncommenting out the integration tests for the ObjC / Swift codegen would be to add another CI service and configure that one for OS X? Maybe CircleCI?

@jgavris
Copy link
Contributor Author

jgavris commented Jun 30, 2016

Resolves #3232

@wing328
Copy link
Contributor

wing328 commented Jul 1, 2016

@jgavris when you've time, please rebase on the latest master to resolve the merge conflicts.

@wing328
Copy link
Contributor

wing328 commented Jul 1, 2016

cc @Edubits @jaz-ah

@wing328 wing328 added this to the v2.2.0 milestone Jul 1, 2016
- Also fix up Enum parameter generation for formParams by extracting _param partial
@jgavris
Copy link
Contributor Author

jgavris commented Jul 1, 2016

@wing328 Updated. Thanks for fixing swift-petstore.sh. I've checked in the sample project using mvn verify -Pswift-client.

@wing328 wing328 modified the milestones: v2.3.0, v2.2.0 Jul 7, 2016
@wing328
Copy link
Contributor

wing328 commented Jul 7, 2016

@jgavris thanks for this and other PRs related to Swift. I've marked these PRs for 2.3.0 release as we'll release 2.2.0 soon.

If there's any Swift PRs you want to get into 2.2.0 stable release, please reply to let us know and we'll discuss on that.

@jgavris
Copy link
Contributor Author

jgavris commented Jul 11, 2016

@wing328 Thanks! We're ok in the meantime using our fork. Let me know if there are any improvements or requirements to make the 2.3.0 release.

@jaz-ah
Copy link
Contributor

jaz-ah commented Jul 13, 2016

+1 looks good to me - @wing328 good to merge here.

@jgavris
Copy link
Contributor Author

jgavris commented Jul 14, 2016

@wing328 Would you object to putting this and my other PR's in 2.2.0? I know of a number of people who want at least the ISO-8601 formatter now.

@wing328
Copy link
Contributor

wing328 commented Jul 14, 2016

@jgavris no objection from me. I'll merge the PR later today.

@jaz-ah thanks for reviewing the PR.

@wing328 wing328 merged commit 0405db7 into swagger-api:master Jul 15, 2016
@jgavris jgavris deleted the swift-iso-date branch July 15, 2016 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants