-
Notifications
You must be signed in to change notification settings - Fork 6k
[Swift] Use ISO-8601 date format #3264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Resolves #3232 |
@jgavris when you've time, please rebase on the latest master to resolve the merge conflicts. |
- Also fix up Enum parameter generation for formParams by extracting _param partial
@wing328 Updated. Thanks for fixing |
@jgavris thanks for this and other PRs related to Swift. I've marked these PRs for 2.3.0 release as we'll release 2.2.0 soon. If there's any Swift PRs you want to get into 2.2.0 stable release, please reply to let us know and we'll discuss on that. |
@wing328 Thanks! We're ok in the meantime using our fork. Let me know if there are any improvements or requirements to make the 2.3.0 release. |
+1 looks good to me - @wing328 good to merge here. |
@wing328 Would you object to putting this and my other PR's in 2.2.0? I know of a number of people who want at least the ISO-8601 formatter now. |
I tried running
./bin/swift-petstore.sh
but it appears that is also broken onmaster
. A potential solution to uncommenting out the integration tests for the ObjC / Swift codegen would be to add another CI service and configure that one for OS X? Maybe CircleCI?