[Scala] Ensure that ApiInvoker.scala can support UUID types
#4807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes #4806 |
|
@log0ymxm thanks for the PR, which has been merged into master. FYI. After the 2.2.2 release, we plan to merge "async-scala" into the "scala" client (which means one single "scala" API client to support both async and sync HTTP calls) (If your company is using Swagger Codegen, please consider adding your company name to this list) |
|
Btw, for your upcoming PRs, I would recommend creating a new branch for the change as per git best practice. |
|
Yeah, my mistake. I noticed that guideline after already submitting the PR. I'll do that in the future. Thanks for accepting the PR. |
|
@log0ymxm np. Your PR (with updated petstore sample) is good 👍 |
wing328
changed the title
ApiInvoker.scala can support UUID typesApiInvoker.scala can support UUID types
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
Add an escape method for handling UUIDs in generated scala client code.