Skip to content

updated core versions #4881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 1, 2017
Merged

updated core versions #4881

merged 16 commits into from
Mar 1, 2017

Conversation

fehguy
Copy link
Contributor

@fehguy fehguy commented Mar 1, 2017

Updated swagger-core, swagger-inflector to current releases

@wing328 wing328 added this to the v2.2.2 milestone Mar 1, 2017
@fehguy
Copy link
Contributor Author

fehguy commented Mar 1, 2017

@wing328 any ideas on this? I'll be able to look more shortly

@wing328
Copy link
Contributor

wing328 commented Mar 1, 2017

Taking a look...

@wing328
Copy link
Contributor

wing328 commented Mar 1, 2017

There's an issue with Travis CI at the moment:

We're experiencing a partial API outage, which is affecting logs availability and our web performance for public repositories.
Please refer to traviscistatus.com for more details.

and I couldn't get any details of the job (e.g log)

Ref: https://www.traviscistatus.com/incidents/hx7cnxbch9xf

@fehguy
Copy link
Contributor Author

fehguy commented Mar 1, 2017

thanks @wing328. I must have gotten lucky with the parser update

@fehguy
Copy link
Contributor Author

fehguy commented Mar 1, 2017

I think there was a problem with the online petstore. Restarting the builds...

@wing328
Copy link
Contributor

wing328 commented Mar 1, 2017

The build failed with the following error:

[ERROR] /home/travis/build/swagger-api/swagger-codegen/samples/server/petstore/jaxrs/jersey2/src/gen/java/io/swagger/api/JacksonJsonProvider.java:[6,42] error: package com.fasterxml.jackson.datatype.joda does not exist
[ERROR] /home/travis/build/swagger-api/swagger-codegen/samples/server/petstore/jaxrs/jersey2/src/gen/java/io/swagger/api/JacksonJsonProvider.java:[7,39] error: package com.fasterxml.jackson.jaxrs.json does not exist
[ERROR] /home/travis/build/swagger-api/swagger-codegen/samples/server/petstore/jaxrs/jersey2/src/gen/java/io/swagger/api/JacksonJsonProvider.java:[15,41] error: cannot find symbol
[ERROR]   symbol: class JacksonJaxbJsonProvider
/home/travis/build/swagger-api/swagger-codegen/samples/server/petstore/jaxrs/jersey2/src/gen/java/io/swagger/api/JacksonJsonProvider.java:[22,32] error: cannot find symbol
[ERROR]   symbol:   class JodaModule
  location: class JacksonJsonProvider
/home/travis/build/swagger-api/swagger-codegen/samples/server/petstore/jaxrs/jersey2/src/gen/java/io/swagger/api/JacksonJsonProvider.java:[25,8] error: cannot find symbol
[INFO] 5 errors

Ref: https://api.travis-ci.org/jobs/206653633/log.txt?deansi=true

I'm looking into the issue...

wing328
wing328 reviewed Mar 1, 2017
View reviewed changes
samples/server/petstore/jaxrs/jersey2/pom.xml
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
<swagger-core-version>1.5.9</swagger-core-version>
<swagger-core-version>1.5.12</swagger-core-version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fehguy This change results in the following errors:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project swagger-jaxrs-server: Compilation failure: Compilation failure:
[ERROR] /private/tmp/master/swagger-codegen/samples/server/petstore/jaxrs/jersey2/src/gen/java/io/swagger/api/JacksonJsonProvider.java:[6,43] package com.fasterxml.jackson.datatype.joda does not exist
[ERROR] /private/tmp/master/swagger-codegen/samples/server/petstore/jaxrs/jersey2/src/gen/java/io/swagger/api/JacksonJsonProvider.java:[7,40] package com.fasterxml.jackson.jaxrs.json does not exist
[ERROR] /private/tmp/master/swagger-codegen/samples/server/petstore/jaxrs/jersey2/src/gen/java/io/swagger/api/JacksonJsonProvider.java:[15,42] cannot find symbol
[ERROR] symbol: class JacksonJaxbJsonProvider
[ERROR] /private/tmp/master/swagger-codegen/samples/server/petstore/jaxrs/jersey2/src/gen/java/io/swagger/api/JacksonJsonProvider.java:[22,33] cannot find symbol
[ERROR] symbol:   class JodaModule
[ERROR] location: class io.swagger.api.JacksonJsonProvider
[ERROR] /private/tmp/master/swagger-codegen/samples/server/petstore/jaxrs/jersey2/src/gen/java/io/swagger/api/JacksonJsonProvider.java:[25,9] cannot find symbol
[ERROR] symbol:   method setMapper(com.fasterxml.jackson.databind.ObjectMapper)
[ERROR] location: class io.swagger.api.JacksonJsonProvider
[ERROR] -> [Help 1]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I manually add the following to the pom.xml, mvn test does not throw any error:

<!-- https://mvnrepository.com/artifact/com.fasterxml.jackson.core/jackson-core -->
<dependency>
    <groupId>com.fasterxml.jackson.core</groupId>
    <artifactId>jackson-core</artifactId>
    <version>2.8.7</version>
</dependency>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added back the dependency via f15267c

@fehguy
Copy link
Contributor Author

fehguy commented Mar 1, 2017

@wing328 Found another missing one. We'll see if it passes

@wing328
Copy link
Contributor

wing328 commented Mar 1, 2017

@fehguy yup, I added those via 9e40700

@wing328
Copy link
Contributor

wing328 commented Mar 1, 2017

The Travis job passed: https://travis-ci.org/swagger-api/swagger-codegen/builds/206707978

@fehguy
Copy link
Contributor Author

fehguy commented Mar 1, 2017

@wing328 shippable is waiting (40 minutes now). Unless you object, I'm going to merge anyway

@wing328
Copy link
Contributor

wing328 commented Mar 1, 2017

No objection. Please go ahead.

(The Shippable test aims to catch issue with mustache templates (e.g. missing close tab)).

@fehguy fehguy merged commit 01f5c1b into master Mar 1, 2017
@fehguy fehguy deleted the swagger-lib-versions branch March 1, 2017 19:12
@fehguy fehguy restored the swagger-lib-versions branch March 1, 2017 19:13
@fehguy fehguy deleted the swagger-lib-versions branch March 1, 2017 19:13
This was referenced Mar 16, 2017
Merged
Merged
spr3nk3ls pushed a commit to spr3nk3ls/swagger-codegen that referenced this pull request Mar 28, 2017
@fehguy
Merge pull request swagger-api#4881 from swagger-api/swagger-lib-vers…
cb6f2d2 
…ions

updated core versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@wing328 wing328 wing328 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@fehguy @wing328