-
Notifications
You must be signed in to change notification settings - Fork 6k
[Scala] add async support to Scala API client #5110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
importMapping.remove("Set"); | ||
importMapping.remove("Map"); | ||
|
||
importMapping.put("DateTime", "org.joda.time.DateTime"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clasnake CI (travis) reported errors. Here is part of the error messages:
Ref: https://s3.amazonaws.com/archive.travis-ci.org/jobs/212403027/log.txt I wonder if you can take a look as I might have made mistakes when resolving conflicts during the cherry-pick. |
@wing328 No problem. I'll take a look. Do I have the permission to update this pr directly? Or shall I create a new one against this one or do you have any other suggestions? |
@clasnake I don't think you've permission as the PR is in the official repo. Please feel free to submit against this one (pr4855_cherrypick) or 2.3.0. |
Closed via #5115 |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0
branch for breaking (non-backward compatible) changes.Description of the PR
Based on #4855
cc @clasnake