Fixes #646: Example field handling has been fixed. #676
Conversation
There was a problem hiding this comment.
@tomtit - notice that this broke the build
There was a problem hiding this comment.
@webron, that is why I've referenced the swagger-api/swagger-core/pull/1002 pull request. The com.wordnik.swagger.models.Response from that change is required. Just don't know how to reference the develop_2.0 branch properly.
There was a problem hiding this comment.
Apologies, I had missed that comment. We can't depend on a SNAPSHOT here though. That means we'll have to wait until swagger-core is released and then modify this PR accordingly. Still not sure what version that's going to end up being.
There was a problem hiding this comment.
@tomtit There is a Java generator that uses examples but the code cannot be merged back to the official repo as the generated code is in Java 8 but swagger-codegen has to be built in Java 7 container.
Here is the repo
https://github.com/networknt/swagger-codegen
And here is the petstore generated
https://github.com/networknt/light-java-example/tree/master/petstore
Fixes #646: Example field handling has been fixed.
The swagger-api/swagger-core/pull/1002 has to be accepted first.
I would suggest to remove escaping of '\n' (i.e. example = example.replaceAll("\n", "\n") in ExampleGenerator and jsonExample = jsonExample.replaceAll("\n", "\n") in NodeJSServerCodegen) and leave this on behalf of particular descendants of the DefaultCodegen class.
As for now only
htmlandnodejsgenerators use examples, while the first outputs examples as is and has the issue reported here, and the former handles escaped '\n' properly