Adds isPrimitiveType flag to CodegenParameter. #773
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required in some languages like Obj-C where there is no automatic value boxing and
handling of primitive types require extra work compared to non-primitive types.
Case in point:
BOOL
type. To assignBOOL
into a dictionary, one needs to box it into anNSValue *
instance, so to build a dictionary for sending form data, for example, youcannot do this in the template:
Because if the parameter ends up being of type
BOOL
, an error about boxing values will begenerated:
The fix is to wrap it in
@()
like so:So a flag is needed in
CodegenParameter
so we can selectively emit the right boxing ornon-boxing assignment in the templates where needed.