Skip to content

Conversation

wing328
Copy link
Contributor

@wing328 wing328 commented May 25, 2015

For #782 and the user reported the fix works.

@wing328 wing328 changed the title [C#] Added restsharp.dll and updated compile.bat [C#] Added RestSharp.dll and updated compile.bat May 25, 2015
@wing328
Copy link
Contributor Author

wing328 commented May 25, 2015

Are you testing against the csharp_add_restsharp_dll branch from my (wing328) repo ?

@lakeba
Copy link

lakeba commented May 25, 2015

Yes I am.

@wing328
Copy link
Contributor Author

wing328 commented May 26, 2015

In another machine, I could pull the branch and execute the batch file to produce IO.Swagger.Client.dll and IO.Swagger.Client.xml

screen shot 2015-05-26 at 6 05 56 pm

@wing328 wing328 mentioned this pull request May 26, 2015
@wing328
Copy link
Contributor Author

wing328 commented May 28, 2015

@uniprof I updated the code to use file separator. Please give it another try.

@lakeba
Copy link

lakeba commented May 28, 2015

@wing328 AH AHHH..... it is working perfect now !!!
How can I merge your csharp_add_restsharp_dll branch with the developer2.0 branch in the main project ?

@wing328
Copy link
Contributor Author

wing328 commented May 28, 2015

@uniprof we don't have permission to merge that. Only the owners of this project has the permission to do so.

How urgent do you need this PR to be merged into develop_2.0 ?

@lakeba
Copy link

lakeba commented May 28, 2015

not much, just want to use the last changes they did.
I can't perform the merge locally?

G.

@wing328
Copy link
Contributor Author

wing328 commented May 28, 2015

I think technically you can get a diff file from this PR (branch: csharp_add_restsharp_dll) and then manually patch your local copy. (not something I would recommend)

@webron
Copy link
Contributor

webron commented May 28, 2015

@uniprof - you can clone @wing328's fork, and sync the branch with develop_2.0 for now. That's pretty much it.

fehguy added a commit that referenced this pull request Jun 5, 2015
[C#] Added RestSharp.dll and updated compile.bat
@fehguy fehguy merged commit b41e88e into swagger-api:develop_2.0 Jun 5, 2015
@wing328 wing328 mentioned this pull request Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants