[Python] Update Minimum Required Versions in setup.mustache #9211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set `certifi` to be not older than `2017.4.17` (it's the minimum version required by popular `requests` package) Set `python-dateutil` minimum version to `2.1` (it's also minimum version required by `botocore` package) Bump `urllib3` minimum required version to `1.23` as there were known vulnerabilities in lesser versions PyUp Safety DB https://pyupio.github.io/safety-db/ (look for urllib3) Snyk Vulnerability DB https://snyk.io/vuln/search?q=urllib3&type=pip
|
CC: @kenjones-cisco |
|
LGTM! |
ustinov
changed the title
|
Thanks for approval, @kenjones-cisco! I don't have write access here, so feel free to merge it. |
|
thanks a lot @ustinov ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
certifito be not older than2017.4.17(it's the minimum version required by popularrequestspackage)Set
python-dateutilminimum version to2.1(it's also minimum version required bybotocorepackage)Bump
urllib3minimum required version to1.23as there were known vulnerabilities in lesser versionsPyUp Safety DB https://pyupio.github.io/safety-db/ (look for urllib3)
Snyk Vulnerability DB https://snyk.io/vuln/search?q=urllib3&type=pip
Resolves #9201
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)