Throw more specific exceptions in JsonPatch::import()
#54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
outdooracorn
commented
Oct 13, 2022
outdooracorn
commented
- InvalidOperationException
- MissingFieldException
- InvalidOperationException - MissingFieldException
outdooracorn
changed the title
JsonPatch::import()`JsonPatch::import()
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
- Coverage 96.63% 95.96% -0.68%
==========================================
Files 10 12 +2
Lines 535 545 +10
==========================================
+ Hits 517 523 +6
- Misses 18 22 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Sorry, was meant to make the PR against the WMDE fork. 🤦♂️ What you get for late night coding and the GitHub UI being too "helpful"! 😅 We will create a PR from our fork once finished updates and tested with our codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.