Skip to content

Use Schema constants for type values instead of string literals #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2019

Conversation

vearutop
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 21, 2019

Codecov Report

Merging #22 into master will increase coverage by 0.28%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #22      +/-   ##
============================================
+ Coverage     87.05%   87.33%   +0.28%     
- Complexity      458      459       +1     
============================================
  Files            37       37              
  Lines          1244     1248       +4     
============================================
+ Hits           1083     1090       +7     
+ Misses          161      158       -3
Impacted Files Coverage Δ Complexity Δ
src/PhpDoc.php 60.6% <ø> (-2.26%) 14 <0> (-1)
src/JsonSchema/SchemaBuilder.php 93.07% <87.5%> (+0.5%) 97 <0> (+2) ⬆️
src/JsonSchema/TypeBuilder.php 95.45% <0%> (+2.27%) 40% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63a710a...ae39c2a. Read the comment docs.

@vearutop vearutop merged commit 32fa90d into master Sep 21, 2019
@vearutop vearutop deleted the symbolize-types branch September 21, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant