Skip to content

Nullable properties #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2019
Merged

Conversation

cussrox
Copy link
Contributor

@cussrox cussrox commented Oct 24, 2019

This PR fixes #25.

@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #26 into master will increase coverage by 0.27%.
The diff coverage is 87.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #26      +/-   ##
============================================
+ Coverage     87.36%   87.63%   +0.27%     
- Complexity      466      493      +27     
============================================
  Files            37       37              
  Lines          1258     1310      +52     
============================================
+ Hits           1099     1148      +49     
- Misses          159      162       +3
Impacted Files Coverage Δ Complexity Δ
src/PhpClassProperty.php 62.96% <100%> (+6.44%) 11 <2> (+2) ⬆️
src/PhpClass.php 98.33% <100%> (+0.33%) 21 <0> (+2) ⬆️
src/JsonSchema/PhpBuilder.php 83.43% <83.72%> (-0.54%) 64 <22> (+23)
src/PhpNamedVar.php 63.04% <0%> (+4.34%) 18% <0%> (ø) ⬇️
src/Traits/Description.php 80% <0%> (+20%) 4% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 989bc3a...abee879. Read the comment docs.

@vearutop vearutop merged commit da76d16 into swaggest:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use phpdoc for nullable properties
2 participants