-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use early overrides to allow converting unsupported types. #1209
Conversation
- Convert types using overrides before other checks are made. This makes it possible, for example, to replace all occurrences of sql.NullString with string. - Include an example with .swaggo rules.
Codecov Report
@@ Coverage Diff @@
## master #1209 +/- ##
==========================================
- Coverage 94.90% 94.83% -0.08%
==========================================
Files 14 14
Lines 2611 2614 +3
==========================================
+ Hits 2478 2479 +1
- Misses 73 74 +1
- Partials 60 61 +1
Continue to review full report at Codecov.
|
@smatric Good job. Would you mind writing unit tests to cover new code?
|
Hi @ubogdan, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please fix the conflict in parser.go. |
…1206) Co-authored-by: jixiufeng <jixiuf@luojilab.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@smatric Thanks for your contribution. |
Describe the PR
Convert types using overrides before other checks are made. This makes it possible, for example, to replace all occurrences of sql.NullString with string. Without this feature, every field of unsupported type has to be tagged with
swaggertype
in parameter structs.Relation issue
#1208