Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dep latest swaggo/gin-swagger #825

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Conversation

jakesylvestre
Copy link
Contributor

@jakesylvestre jakesylvestre commented Nov 2, 2020

Describe the PR

Updates gin-swagger to the latest version

Relation issue
swaggo/gin-swagger#128

Additional context

A dependency got deleted (see ugorji/go#337) which causes any builds to fail that include an indirect dependency on github.com/ugorji/go@v1.1.5-pre. This has been patched in the latest version of gin-swagger and no longer breaks downstream dependencies (see: golang/go#30354)

@jakesylvestre jakesylvestre mentioned this pull request Nov 2, 2020
@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #825 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #825   +/-   ##
=======================================
  Coverage   82.53%   82.53%           
=======================================
  Files           8        8           
  Lines        1626     1626           
=======================================
  Hits         1342     1342           
  Misses        168      168           
  Partials      116      116           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fdbe7a...4ea84ae. Read the comment docs.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit 3f47d68 into swaggo:master Nov 4, 2020
@ubogdan
Copy link
Contributor

ubogdan commented Nov 4, 2020

@jakesyl Thanks for your contribution.

@jakesylvestre
Copy link
Contributor Author

@ubogdan in light of #826/#827 it might make sense to make a new release with this. I've provided a workaround on #825 (namely using github.com/swaggo/swag v1.6.10-0.20201104153820-3f47d68f8872, but would be great if you could run a gorelease)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants