Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Portable" property is a misnomer #1695

Closed
kostmo opened this issue Dec 30, 2023 · 0 comments · Fixed by #1706
Closed

"Portable" property is a misnomer #1695

kostmo opened this issue Dec 30, 2023 · 0 comments · Fixed by #1706
Labels
Z-Feature A new feature to be added to the game.

Comments

@kostmo
Copy link
Member

kostmo commented Dec 30, 2023 •
edited by byorgey
Loading

Entities that are not portable may not be grabed or harvested, or obtained as the result of drill. However, such entities can still exist in the inventory and certainly don't preclude movement. Non-portable entities may already be specified in the inventory at the outset of a scenario, or they may enter the inventory by via make, or be salvageed, or be given, etc. In fact, certain scenario mechanics already depend on the behavior being so.

Perhaps a better term for the property would be pickable?
@kostmo kostmo added the Z-Feature A new feature to be added to the game. label Dec 30, 2023
@kostmo kostmo mentioned this issue Jan 4, 2024
Merged
@mergify mergify bot closed this as completed in #1706 Jan 5, 2024
mergify bot pushed a commit that referenced this issue Jan 5, 2024
@kostmo
rename 'portable' to 'pickable' (#1706)
47a8ffe 
Closes #1695.

Updating occurrences was pretty easy:

    yq --inplace '(.[].properties[] | select(. == "portable")) |= "pickable"' data/entities.yaml

and

    find data/scenarios -type f -name '*.yaml' -print0 | xargs --max-args 1 --null yq --inplace '(select(has("entities")) | .entities[] | select(has("properties")) | .properties[] | select(. == "portable")) |= "pickable"'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Z-Feature A new feature to be added to the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rename 'portable' to 'pickable' swarm-game/swarm
1 participant
@kostmo