User-controllable sort criteria #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostmo
force-pushed
the
inventory-sort
branch
from
7ce915a
to
48cc473
Compare
kostmo
commented
Oct 27, 2022
kostmo
force-pushed
the
inventory-sort
branch
from
48cc473
to
81b20bf
Compare
kostmo
force-pushed
the
inventory-sort
branch
from
81b20bf
to
ba22fa4
Compare
kostmo
force-pushed
the
inventory-sort
branch
from
ba22fa4
to
f475d9f
Compare
|
All comments resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the inventory pane is selected (Alt+e), one can use the
;and:keys to cycle sort criteria and sort direction, respectively.This functionality is implemented in a new module to avoid exacerbating #707.
Note that
entityPropertiesmay be an unreliable criteria to sort, because it is a list that itself may contain duplicates or items in unpredictable order. Perhaps this field should be made aSet(#794).