fix(es/modules): Preserve extensions

[kdy1]

Description:

Related issue:

• Closes Package imports are rewritten incorrectly if they have 3 or more segments separated by dots #6209.

[kdy1]

swc-bump:

• dbg-swc

[alexander-akait]

I think it was workaround for ts, i.e.

import foo from "./test.ts"

to

import foo from "./test"

So test.js can be resolved, not sure why it was implemented in this way 😕

babel keeps exetensions too

[kdy1]

🤣 I made lots of mistakes

[swc-bot]

Automated review comment generated by auto-rebase script

[Nickersoft]

Hey @kdy1! I just had to downgrade because of this change, for the exact reason I think you mentioned in your comment 😅 I have a NestJS project where none of my imports use extensions (as per NestJS convention) – however, now my TypeScript compile from this:

import foo from './bar.module';

to

import foo from './bar.module.ts';

even though SWC is generating a directory full of JavaScript files. My code crashes because it can't find bar.module.ts (because it's compiled to bar.module.js). Even changing my code to import from bar.module.js (the weird ESM convention for TS), SWC still generates the import with the .ts file extension lol.

Is there any workaround for this? Or am I stuck on 1.3.14 for now?

[kdy1]

Use .js for omports instead. swc is not a fixer. Your code is wrong. swc should not fix it.

[kdy1]

You can fix your code. It's not a something to workaround. Your code is simply wrong.

[Nickersoft]

As I mentioned, .js imports get rewritten back to .ts anyway.

I spent some time looking into this, and realized that as long as you have a paths option in .swcrc, it will break imports.

I set up this example repo.

The project is ESM, and with a main.ts file that imports a TypeScript file (import.ts) using a .js extension. There is a bogus paths entry in .swcrc (doesn't matter if it's valid or not – I checked). Run npm install and then npm run build. It'll compile to a dist directory, but the code will be un-runnable because the .js import was rewritten back to a .ts import.

This is a legitimate problem, regardless of how you're importing your modules.

[kdy1]

My bad, I misread your comment, sorry. Can you file an issue?

[Nickersoft]

Yep 👍🏻