fix: satisfies expressions are parsed as TsSatisfiesExpression #6354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nissy-dev
changed the title
|
node bindings build failed. Based on the error messages, I seem the old version swc_ecma_parser is compiled when running In my local PC, I ran the following command and passed... Maybe, cache problem...? |
|
I think this is a problematic, but you need to patch local crates using Lines 716 to 719 in 8123bf0 |
nissy-dev
commented
Nov 6, 2022
nissy-dev
commented
Nov 6, 2022
Comment on lines
+40
to
+42
| const _b = require(\\"../packages/b/src/index.ts\\"); | ||
| async function display() { | ||
| const displayA = await Promise.resolve().then(()=>/*#__PURE__*/ _interopRequireWildcard(require(\\"../packages/a/src/index\\"))).then((c)=>c.displayA); | ||
| const displayA = await Promise.resolve().then(()=>/*#__PURE__*/ _interopRequireWildcard(require(\\"../packages/a/src/index.ts\\"))).then((c)=>c.displayA); |
There was a problem hiding this comment.
After applying patch dependencies correctly, this test failed. I seem #6339 causes this issue. Therefore, I updated snapshot.
swc-bot
reviewed
Nov 7, 2022
dsherret
reviewed
Nov 7, 2022
| #[tag("TsSatisfactionExpr")] | ||
| TsSatisfaction(TsSatisfactionExpr), | ||
| #[tag("TsSatisfiesExpression")] | ||
| TsSatisfies(TsSatisfiesExpr), |
There was a problem hiding this comment.
I will no longer have Benny Benassi stuck in my head while working with this. Thank you!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fix #6238
BREAKING CHANGE:
Related issue (if exists): #6238