Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding call stack section #178

Closed
wants to merge 1 commit into from

Conversation

c-martinez
Copy link

In the Programming with R lesson, the Creating functions topic contains a section about call stack. The python lesson also has a Creating functions topic, which does not contain this section. It would be consistent to teach about call stacks in both languages. This pull request adds such section to the Python lesson.

@abostroem
Copy link
Contributor

This adds a significant new section to the lessons. What part of the Python lesson would you remove in order to include this section?

@c-martinez
Copy link
Author

I am not suggesting removing any part of the Python lesson. This new section does make the lesson longer, but it is just as long as its R counterpart. If adding this requires removing another section of the lesson, then perhaps a section of the R lesson should be removed as well?

@tbekolay
Copy link
Contributor

tbekolay commented Jan 4, 2016

Hi @c-martinez, we actually did have the mirrored content previously; it is still available in the discussion page. In the end, we found that most instructors teaching the lesson skipped this material, and so we chose to remove it from the main lessons, but left it in the discussion in case anyone still wanted to use it. I would be curious to know if those teaching R actually go over this content or skip it frequently as well...

@c-martinez
Copy link
Author

Hi @tbekolay, ah -- good to know. So perhaps instead of this PR adding a section to the python lesson, I should send a new PR removing the section from the R lesson, to start the discussion ?

@tbekolay
Copy link
Contributor

tbekolay commented Jan 4, 2016

Sure, that sounds like a good way forward :)

@tbekolay
Copy link
Contributor

Looks like swcarpentry/r-novice-inflammation#158 has now been resolved, so closing, thanks @c-martinez!

@tbekolay tbekolay closed this Jun 21, 2016
tbekolay pushed a commit that referenced this pull request Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants