[PATCH] [Bug] update makeTransformation to consider svgs where width #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was using the commandline tool to convert svg icons to SF Symbols. There were a few examples where the height of the icon is less than its width, causing the computation of the scale in `Renderer.SFSymbol.swift` `makeTransformation` to be too large. This resulted in the width of the symbol being incorrect. I have included one of the icon svg tiles (dash.svg) and a test to make sure the bounds are computed properly. I’m not sure if this is the proper fix, but a repro step is very easy. Simply run: ``` SwiftDraw dash.svg —format sfsymbol ```
swhitty
approved these changes
May 27, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
=======================================
Coverage 85.36% 85.36%
=======================================
Files 77 77
Lines 7009 7009
=======================================
Hits 5983 5983
Misses 1026 1026
☔ View full report in Codecov by Sentry. |
|
0.14.0 includes the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using the commandline tool to convert svg icons to SF Symbols. There were a few examples where the height of the icon is less than its width, causing the computation of the scale in
Renderer.SFSymbol.swiftmakeTransformationto be too large. This resulted in the width of the symbol being incorrect.I have included one of the icon svg tiles (dash.svg) and a test to make sure the bounds are computed properly. I’m not sure if this is the proper fix, but a repro step is very easy. Simply run:
Here is the input file:
Here is the SF Symbol file before this patch:
And here is the SF Symbol file afterwards:
