Skip to content

Conversation

swhitty
Copy link
Owner

@swhitty swhitty commented Aug 5, 2025

The SFSymbol alignment logic was updated within #88 to be more precise and similar to the alignment of official SFSymbols:

updated

This change may be unexpected for some users so this PR adds the --legacy option to preserve the alignment from previous version

--legacy             use the original, less precise alignment logic from earlier swiftdraw versions.
legacy

Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 73.49398% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.60%. Comparing base (dd11d1d) to head (73cb83c).

Files with missing lines Patch % Lines
...Draw/Sources/CommandLine/CommandLine+Process.swift 0.00% 13 Missing ⚠️
SwiftDraw/Sources/Renderer/Renderer.SFSymbol.swift 75.00% 8 Missing ⚠️
...aw/Sources/CommandLine/CommandLine.Arguments.swift 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   89.66%   89.60%   -0.06%     
==========================================
  Files         144      144              
  Lines       12148    12181      +33     
==========================================
+ Hits        10892    10915      +23     
- Misses       1256     1266      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@swhitty swhitty merged commit d30c94b into main Aug 5, 2025
18 of 20 checks passed
@swhitty swhitty deleted the legacy-alignment branch August 5, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant