Filenames are not highlighted correctly in compilation buffers

[dabrahams]

Huh, something's not quite right here that I didn't notice until I upgraded to use the latest swift-mode and removed my workarounds. Now regular errors from the Swift compiler don't show up using the compilation-error face.

Before the upgrade:

The filename is rendered as compilation-error.
The line number and column are rendered as compilation-line-number and compilation-column-number
The rest of the line is just rendered as default.

After:

In this line:

The filename is rendered as underline.
The line number and column are rendered as compilation-line-number and compilation-column-number, as expected.
The rest of the line is just rendered as error.

[dabrahams]

PEBKAC!

[taku0]

When extracting filenames with a function rather than a regexp matching group, the filename is not highlighted:
https://github.com/emacs-mirror/emacs/blob/2606e3dd994d2d75850630707c00c0156afced9a/lisp/progmodes/compile.el#L1579-L1583

This can be fixed by highlighting the filename in our matching function. But highlighting the part " error:" is another thing. It is not standardized and Swift tools use various strings. Do you want to highlight it?

[taku0]

Fixed by 9fbcad0. We do not highlight " error:" part for now.