Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object-based JSON serialization #103

Merged
merged 3 commits into from
Apr 14, 2015

Conversation

mfine
Copy link
Contributor

@mfine mfine commented Apr 14, 2015

Provide full serialization of JSON objects. This change introduces a static from_json method for each message class, and a to_json method for each message class. This enables serializing and deserializing full objects to and from JSON. It's not super optimal on deserialization in that it parses out the JSON and then parses it again through construct, but that can be fixed up later (it wasn't trivial to reconstitute the construct containering). Tests were added around the JSON serialization and deserialization via raw_json outputs in the test YAML. Sub-objects do not have JSON serdes methods.

/cc @mookerji

@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/8/
Test PASSed.

@mfine mfine mentioned this pull request Apr 14, 2015
@mfine
Copy link
Contributor Author

mfine commented Apr 14, 2015

Fixes #103.

@mookerji
Copy link
Contributor

retest this please

@swiftnav-jenkins
Copy link
Contributor

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/12/
Test FAILed.

@mfine
Copy link
Contributor Author

mfine commented Apr 14, 2015

Hmmm, doesn't like the requirements file in tox?

Could not open requirements file: [Errno 2] No such file or directory: 'requirements.txt'
ERROR: could not install deps [-rrequirements.txt, pyyaml]

@mfine
Copy link
Contributor Author

mfine commented Apr 14, 2015

Screw it, I'll put pyyaml it in the requirements.txt - tox and other stuff is already in there.

@swiftnav-jenkins
Copy link
Contributor

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/13/
Test FAILed.

@swiftnav-jenkins
Copy link
Contributor

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/14/
Test FAILed.

@mfine
Copy link
Contributor Author

mfine commented Apr 14, 2015

retest this please

@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/16/
Test PASSed.

mookerji added a commit that referenced this pull request Apr 14, 2015
@mookerji mookerji merged commit e6d94aa into swift-nav:master Apr 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants