Improvements to MSG_VEL_COG [TES-129] #1093
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: the
MSG_VEL_COG
spec was defined at the end of 2021 to support a customer need for non-fusion heading output. The message was defined quickly and without rigorous review, and a handful of issues were identified only after it was released. Upon further review, it was determined that we should update the message to fix these issues rather than define a new message altogether.Its use has been limited to a single release branch (Starling v1.2.20), meaning the message has only been used by one external stakeholder. Deprecation is not imperative in this case to maintain usability, so the risk of this update appears relatively small and is favored as a quicker and less cumbersome solution.
Changes made to the message definition:
flags
field increased from 8 bits to 16vel_d
field tov_up
All other files changed as a result of updated bindings or updated test definitions.
Note: I had some trouble updating the test definitions, but eventually worked something out. My ad hoc procedure is written out here.