Add MSG_STATUS_JOURNAL [4.1.x] #1126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jungleraptor
suggested changes
Apr 28, 2022
silverjam
force-pushed
the
silverjam/add-msg-status-journal
branch
from
9346621 to
2f44b13
Compare
|
Waiting for docker run on my machine to get to the Rust source |
silverjam
force-pushed
the
silverjam/add-msg-status-journal
branch
from
2f44b13 to
7b4cb25
Compare
silverjam
force-pushed
the
silverjam/add-msg-status-journal
branch
from
7b4cb25 to
9aa6e56
Compare
jungleraptor
approved these changes
May 2, 2022
silverjam
commented
May 2, 2022
silverjam
commented
May 2, 2022
|
|
||
| ck_assert_msg(dummy_wr == sizeof(encoded_frame), | ||
| "not enough data was written to dummy_buff"); | ||
| "not enough data was written to dummy_buff (expected: %zu, actual: %zu)", sizeof(encoded_frame), dummy_wr); |
There was a problem hiding this comment.
Added to help with debugging
silverjam
commented
May 2, 2022
| """ | ||
| assert sbp.crc == int(test_case['crc'], 0), "Invalid crc." | ||
| expected = int(test_case['crc'], 0) | ||
| assert sbp.crc == expected, "Invalid crc. Actual: {:x} vs expected: {:x}.".format(sbp.crc, expected) |
There was a problem hiding this comment.
Debugging aid/improvement
notoriaga
approved these changes
May 2, 2022
RReichert
approved these changes
May 2, 2022
There was a problem hiding this comment.
LGTM, thanks @silverjam .
This PR is currently being used by:
woodfell
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/devinfra
Adds new MSG_STATUS_JOURNAL, see https://swift-nav.atlassian.net/l/c/yYraQXHA
API compatibility
Does this change introduce a API compatibility risk? -> No, just introducing a new message.
Related PRs