-
Notifications
You must be signed in to change notification settings - Fork 96
Added input and output parameters to rust sbp2json #1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
20499d1
to
fe6f31d
Compare
fe6f31d
to
e3f5fd4
Compare
is there a way to make clap do without the -- parameter? i just saw the comment on the ticket, would it have to instead use std::env::args hmm |
yeah if you don't specify long/short it should be a positional argument instead of a flag |
e3f5fd4
to
0bdffec
Compare
0bdffec
to
7f56c4c
Compare
/// | ||
/// Typical usage: | ||
/// | ||
/// json2json --input [PATH] --output [PATH] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update these example usage strings since we're not using option args (using positional args instead), example:
json2json [<INPUT> [<OUTPUT>]]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does --help show if we remove that completely? I feel like that's pretty similar to what clap will generate anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, probably better to just remove this
Description
--input
and--output
parameters to rust sbp2json, json2json, json2sbpJIRA Reference
https://swift-nav.atlassian.net/browse/DEVINFRA-738