Skip to content

validator: skip stubbed messages [OTA-150] #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2022
Merged

validator: skip stubbed messages [OTA-150] #1151

merged 1 commit into from
May 19, 2022

Conversation

silverjam
Copy link
Contributor

@silverjam silverjam commented May 19, 2022 •
edited
Loading

Description

@swift-nav/devinfra

Tested on a staging branch PR:

INFO:root:Processing Definition: 570 (current: MSG_GPS_LEAP_SECOND, previous: MSG_GPS_LEAP_SECOND)
WARNING:root:Found stubbed message, skipping validation check...
INFO:root:Processing Definition: 580 (current: MSG_ITRF, previous: MSG_ITRF)
WARNING:root:Found stubbed message, skipping validation check...
INFO:root:Processing Package: swiftnav.sbp.settings

API compatibility

Does this change introduce a API compatibility risk? -> It introduces a change to the validator to allow stubbed messages to change without failing the PR checks.

API compatibility plan

If the above is "Yes", please detail the compatibility (or migration) plan: stubbed messages are designed to change, so we don't need compatibility.

JIRA Reference

https://swift-nav.atlassian.net/browse/OTA-150

@silverjam silverjam requested a review from a team as a code owner May 19, 2022 20:08
@silverjam silverjam requested a review from fpezzinosn May 19, 2022 20:08
@silverjam silverjam merged commit 5b40cd9 into master May 19, 2022
@silverjam silverjam deleted the silverjam/exception-for-stubs branch May 19, 2022 21:13
@swiftnav-svc-jenkins swiftnav-svc-jenkins mentioned this pull request Oct 20, 2022
Closed
@swiftnav-svc-jenkins swiftnav-svc-jenkins mentioned this pull request Nov 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpezzinosn fpezzinosn fpezzinosn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silverjam @fpezzinosn