Update navigation stubbed msgs names [OTA-161] #1156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
fpezzinosn
force-pushed
the
fpezzinosn/OTA-161-main
branch
from
eecd394 to
62aa155
Compare
fpezzinosn
commented
Jun 7, 2022
|
@swift-nav/devinfra Ready for review! |
This reverts commit 4c0e7ac.
fpezzinosn
force-pushed
the
fpezzinosn/OTA-161-main
branch
from
62aa155 to
94eef9b
Compare
Merged
silverjam
approved these changes
Jun 9, 2022
notoriaga
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/devinfra
Updates the names of two of the stubbed navigation messages.
GPSLeapSecond -> UTCLeapSecond
ITRF -> FrameTransformationParams
These are more appropriate names for the proposed new messages.
API compatibility
Does this change introduce a API compatibility risk?
Two messages are changing names, but since they are stubbed messages not yet published, no one should be consuming them.
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
JIRA Reference
https://swift-nav.atlassian.net/browse/OTA-161