Skip to content

Conversation

adrian-kong
Copy link
Contributor

@adrian-kong adrian-kong commented Jun 9, 2022

Description

right now it doesn't upload the linux build

since linux specifies binary target, directory becomes
/target/x86_64-unknown-linux-musl/release
where normally it should be
/target/release

and we want to zip it up to end up in the top folder
/
so we will just zip it up with an extra level

this is due to #1161

@adrian-kong adrian-kong requested a review from a team as a code owner June 9, 2022 04:41
@adrian-kong adrian-kong changed the title fixing build script fixing rust build script Jun 9, 2022
@adrian-kong adrian-kong requested a review from joelynch June 9, 2022 04:46
@adrian-kong adrian-kong enabled auto-merge (squash) June 9, 2022 04:54
@adrian-kong adrian-kong merged commit 94102d5 into master Jun 9, 2022
@adrian-kong adrian-kong deleted the adrian/fixbuild branch June 9, 2022 04:57
@silverjam
Copy link
Contributor

@adrian-kong Where we able to validate this? Or do we need to wait until the next release?

@adrian-kong
Copy link
Contributor Author

@adrian-kong Where we able to validate this? Or do we need to wait until the next release?

here https://github.com/swift-nav/libsbp/runs/6806332387?check_suite_focus=true
i've uploaded the binary to the 4.3.3 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants