Skip to content

Conversation

martin4861
Copy link
Contributor

@martin4861 martin4861 commented Jul 25, 2025

Description

@swift-nav/algint-team

Implement a Bazel 7 compatible MODULE file.
Uses swift-nav/rules_swiftnav#167

The MODULE file is sufficient to consume libsbp. However, building libsbp using the MODULE is not yet supported on all platforms (e.g. darwin aarch64 is not yet working). The local development in this repo is still on Bazel 6/WORKSPACE, therefore nothing changes.

Needed rules_swiftnav changes: swift-nav/rules_swiftnav#167

API compatibility

Does this change introduce a API compatibility risk?

No!

API compatibility plan

If the above is "Yes", please detail the compatibility (or migration) plan:

Not needed.

JIRA Reference

https://swift-nav.atlassian.net/browse/AP-4083

@martin4861 martin4861 force-pushed the martin4861/implement-MODULE branch 3 times, most recently from 2a8c159 to c4ede65 Compare July 25, 2025 11:29
@martin4861 martin4861 changed the title implement MODULE [WIP] Implement MODULE [WIP] Jul 25, 2025
@martin4861
Copy link
Contributor Author

martin4861 commented Jul 28, 2025

  • Add comment about MODULE/WORKSPACE compatibility

…ut clang

Readd hedron

Fix local_includes

Add notes about MODULE file
@martin4861 martin4861 force-pushed the martin4861/implement-MODULE branch from 9292b88 to 86a913b Compare July 28, 2025 10:18
@martin4861 martin4861 changed the title Implement MODULE [WIP] Implement MODULE [AP-4083] Jul 28, 2025
@martin4861 martin4861 marked this pull request as ready for review July 28, 2025 10:43
@martin4861 martin4861 requested a review from a team as a code owner July 28, 2025 10:43
@martin4861 martin4861 requested review from armallen and woodfell July 28, 2025 10:43
Copy link

Copy link
Contributor

@armallen armallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, I only wonder why we need the .bazelignore change?

@martin4861 martin4861 merged commit 4c8d77e into master Jul 28, 2025
24 checks passed
@martin4861 martin4861 deleted the martin4861/implement-MODULE branch July 28, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants