Skip to content

Add cmake toolchain support for cortex-m7 #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 10, 2018
Merged

Add cmake toolchain support for cortex-m7 #610

merged 5 commits into from
Oct 10, 2018

Conversation

yiiiyang2010
Copy link
Contributor

@yiiiyang2010 yiiiyang2010 commented Oct 8, 2018 •
edited
Loading

  • set fpu as -mfpu=fpv5-d16 for supporting double precision floating point for fpu v5.

@yiiiyang2010 yiiiyang2010 requested a review from mbavaro October 8, 2018 17:17
mbavaro
mbavaro approved these changes Oct 8, 2018
View reviewed changes
Copy link
Contributor

@mbavaro mbavaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, LGTM

c/cmake/Toolchain-gcc-arm-embedded.cmake Outdated

set(CMAKE_C_FLAGS
"${CMAKE_C_FLAGS}"
"-mcpu=cortex-m7 -march=armv7e-m -mthumb"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-march=armv7e-m isn't a flag in the CubeMX Makefile.. should be enforced by mcpu https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html

@yiiiyang2010 yiiiyang2010 merged commit 0071941 into master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mbavaro mbavaro mbavaro approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yiiiyang2010 @mbavaro