-
Notifications
You must be signed in to change notification settings - Fork 96
[ESD-2009] Turn on auto formatting #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current build image might not include clang-format
, here is a snippet from running make -j8 c
using the swiftnav/libsbp-build:2021.04.02
image on my machine:
CMake Warning at cmake/common/ClangFormat.cmake:122 (message):
Could not find appropriate clang-format, targets disabled
Call Stack (most recent call first):
cmake/common/ClangFormat.cmake:218 (early_exit)
CMakeLists.txt:13 (swift_setup_clang_format)
@woodfell please update the README.md/HOWTO.md to point to the new docker image tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the motivation to remove the empty structs? I can't think of a reason to have included them in the first place, but removing them is a breaking change. |
Oops, getting ahead of myself here. Empty structs are one of the problems in libsbp but I'll put them back in for the moment |
e839333
to
1bf3afe
Compare
|
||
/** | ||
* CN/0 of best point [dB Hz] | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is objectively more pretty before than it is after. It used to be visible in 5 lines, now it takes 25,.
This reverts commit 1f031dc.
Enable the clang-format cmake module and run during generation of C source/headers.
.clang-format
imported from Starling.Adjust the C header template slightly to achieve the following:
Previous documentation structure was:
has been changed to
There are no functional changes in this PR. The only places which were edited by hand are:
Suggestion for reviewing:
Review changes to
Makefile
,c/CMakeLists.txt
,c/.clang-format
, andgenerator/sbpg/targets/resources/sbp_messages_template.h
. Copy them in to a fresh checkout of master and runmake c
. Then diff the repo to this branch to confirm that all other changes are as a result of clang-format.