-
Notifications
You must be signed in to change notification settings - Fork 0
use /usr/bin/basename for rules_cc #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
was the error - https://jenkins.ci.swift-nav.com/blue/organizations/jenkins/swift-nav%2Forion_proto/detail/PR-2049/1/pipeline seems to have fixed it on linux/in CI https://github.com/swift-nav/orion_proto/pull/2049/commits/04e119196d51c1a0c1655055a488328771beae23 but I get a different error on mac now
|
]) | ||
else: | ||
link_flags.extend([ | ||
"-B/usr/bin", # Tell clang where to find system linker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was the other fix needed for mac in addition to the basename thing
Another random compatibility issue, after updating the rust tool chain it can't find
basename
when linking with our custom toolchain - copied this from rules_cc https://github.com/bazelbuild/rules_cc/blob/0fee42b524315fd16c197877f24d5b8ba0a9a1ee/cc/private/toolchain/osx_cc_wrapper.sh.tpl#L42I checked and we aren't using any of the other tools they impl that pattern for