Create default feature testcpp for C++ tests #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
commented
Jul 26, 2021
build.rs
Outdated
| if !cfg!(feature = "testcpp") { | ||
| cmake.define("libswiftnav_ENABLE_TESTS", "OFF"); | ||
| } | ||
|
|
||
| cmake | ||
| .profile("Release") |
There was a problem hiding this comment.
Is there a reason we are always using Release profile? If removed, the cmake-rs crate will dynamically set this based on the Rust release profile.
There was a problem hiding this comment.
No specific reason as far as I remember, I think we can remove this if the cmake crate selects this automatically
Avoids these two parts of the cmake rules from performing searches for binaries which will not be used.
jayvdb
force-pushed
the
jayvdb/disable-tests
branch
from
c53c704 to
7338016
Compare
silverjam
approved these changes
Jul 27, 2021
cmake-rs automatically determines the appropriate CMAKE_BUILD_TYPE based on the Rust build profile and env vars OPT_LEVEL and DEBUG.
|
Looks good. Thanks for fixing this up @jayvdb ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows reducing build time by ~1/3