Simplify RESP Parsing and Redis Channel Handlers #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: As it stands, the parsing / encoding implementations for RESP was directly tied to the NIO Channel Handlers. Unit tests were sloppily spread across multiple files and it made it difficult to explicitly separate out the Channel Handler behavior from the RESP specification implementation. Modifications: - Add: `RESPTranslator` enum helper object with static methods that only handles RESP parsing / encoding - Rename: `RESPEncoder` to `RedisMessageEncoder` - Rename: `RESPDecoder` to `RedisByteDecoder` Results: It should be easier to understand what type is intended to be used as part of a NIO channel pipeline while still having a direct way of parsing / encoding between Swift types and the RESP specification. Unit tests should be more maintainable as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As it stands, the parsing / encoding implementations for RESP was directly tied to the NIO Channel Handlers.
Unit tests were sloppily spread across multiple files and it made it difficult to explicitly separate out
the Channel Handler behavior from the RESP specification implementation.
Modifications:
RESPTranslatorenum helper object with static methods that only handles RESP parsing / encodingRESPEncodertoRedisMessageEncoderRESPDecodertoRedisByteDecoderResults:
It should be easier to understand what type is intended to be used as part of a NIO channel pipeline while
still having a direct way of parsing / encoding between Swift types and the RESP specification.
Unit tests should be more maintainable as well.