Reuse DispatchQueue for multiple Invocations #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
commented
Mar 26, 2020
| @@ -25,17 +25,27 @@ import NIO | |||
| /// The `EventLoopLambdaHandler` will execute the Lambda on the same `EventLoop` as the core runtime engine, making the processing faster but requires | |||
| /// more care from the implementation to never block the `EventLoop`. | |||
| public protocol LambdaHandler: EventLoopLambdaHandler { | |||
| @inlinable var dispatchQueue: DispatchQueue { get } | |||
There was a problem hiding this comment.
@weissi does @inlinable make any sense here?
There was a problem hiding this comment.
nope, it's just a function call, no generics or optimisation potential
Closed
fabianfett
force-pushed
the
reusable-DispatchQueue
branch
from
d55af4a to
a7c5813
Compare
tomerd
reviewed
Mar 26, 2020
| @@ -25,17 +25,27 @@ import NIO | |||
| /// The `EventLoopLambdaHandler` will execute the Lambda on the same `EventLoop` as the core runtime engine, making the processing faster but requires | |||
| /// more care from the implementation to never block the `EventLoop`. | |||
| public protocol LambdaHandler: EventLoopLambdaHandler { | |||
| var dispatchQueue: DispatchQueue { get } | |||
There was a problem hiding this comment.
should we call this offloadQueue or something the tells what this is about?
tomerd
reviewed
Mar 26, 2020
| func handle(context: Lambda.Context, payload: In, callback: @escaping (Result<Out, Error>) -> Void) | ||
| } | ||
|
|
||
| private extension Lambda { | ||
| static let handlerQueue = DispatchQueue(label: "LambdaHandler.offload") |
fabianfett
force-pushed
the
reusable-DispatchQueue
branch
from
a7c5813 to
1ac951c
Compare
Merged
tomerd
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix #39