Move KafkaClient to RD* namespace
#89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Our `KafkaClient` class has evolved into a wrapper of `rd_kafka_*` C functions. Therefore I thought it is reasonable to move it to the `RDKafka*` namespace (conceptually) and remove the imports of `CRDKafka` in `KafkaConsumer` and `KafkaProducer`. Modifications: * `KafkaConsumer`: remove `CRDKafka` import * `KafkaProducer`: remove `CRDKafka` import * rename `KafkaClient -> `RDKafkaClient` and move it to the `RDKafka` folder * delete `RDKafka.swift` and move `create/makeClient` factory method to `RDKafkaClient`
FranzBusch
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Our
KafkaClientclass has evolved into a wrapper ofrd_kafka_*Cfunctions. Therefore I thought it is reasonable to move it to the
RDKafka*namespace (conceptually) and remove the imports ofCRDKafkain
KafkaConsumerandKafkaProducer.Modifications:
KafkaConsumer: removeCRDKafkaimportKafkaProducer: removeCRDKafkaimportKafkaClient ->RDKafkaClientand move it to theRDKafka`folder
RDKafka.swiftand movecreate/makeClientfactory method toRDKafkaClient