KafkaProducer: refactor flushing
#94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FranzBusch : how shall we go about vending the |
We should put it into our configuration struct. |
felixschlegel
force-pushed
the
fs-kafka-producer-refactor-flush
branch
2 times, most recently
from
c90ba5a to
b20104e
Compare
FranzBusch
reviewed
Jul 20, 2023
Sources/SwiftKafka/KafkaClient.swift
Outdated
| /// Flush any outstanding produce requests. | ||
| /// | ||
| /// Parameters: | ||
| /// |
| /// Default: `10000` | ||
| public var flushTimeoutMilliseconds: Int = 10000 { | ||
| didSet { | ||
| precondition(0...Int(Int32.max) ~= self.flushTimeoutMilliseconds) |
There was a problem hiding this comment.
Can we provide a message here as well when we fail the precondition please
Motivation:
With our own flushing implementation we were flushing until `rd_kakfa_outq_len`
reached ``0`. However `rd_kakfa_outq_len` also takes other events such
as statistics into account which led to a race where we were flushing
for a very long time because more and more other events were produced to
the queue while we were flushing.
Modifications:
* `KafkaClient`:
* remove `var outgoingQueueSize`
* add new method `flush(timeoutMilliseconds:)` that executes the
blocking `rd_kafka_flush` call on a `DispatchQueue` but vends this
as an `async func`
* `KafkaProducer`:
* rename `KafkaProducer.StateMachine.State.flushing` to
`KafkaProducer.StateMachine.State.finishing`
* invoke `KafkaClient.flush` before terminating poll loop
Modifications: * add messages to `preconditions` * remove extra line in `RDKafkaClient.flush`'s parameter documentation
felixschlegel
force-pushed
the
fs-kafka-producer-refactor-flush
branch
from
6d43007 to
6aa35f5
Compare
FranzBusch
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
With our own flushing implementation we were flushing until
rd_kakfa_outq_lenreached
0. Howeverrd_kakfa_outq_lenalso takes other events suchas statistics into account which led to a race where we were flushing
for a very long time because more and more other events were produced to
the queue while we were flushing.
Modifications:
KafkaClient:var outgoingQueueSizeflush(timeoutMilliseconds:)that executes theblocking
rd_kafka_flushcall on aDispatchQueuebut vends thisas an
async funcKafkaProducer:KafkaProducer.StateMachine.State.flushingtoKafkaProducer.StateMachine.State.finishingKafkaClient.flushbefore terminating poll loop