Adapt Service protocol from swift-service-lifecycle
#37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkz2
changed the title
Service protocol from swift-service-lifecycleService protocol from swift-service-lifecycle
FranzBusch
reviewed
Aug 24, 2023
Comment on lines
33
to
41
| let serviceGroupConfiguration = ServiceGroupConfiguration( | ||
| services: [ServiceGroupConfiguration.ServiceConfiguration(service: memcacheConnection)], | ||
| gracefulShutdownSignals: [], | ||
| cancellationSignals: [], | ||
| logger: self.logger | ||
| ) | ||
|
|
||
| // Initialize the service group | ||
| let serviceGroup = ServiceGroup(configuration: serviceGroupConfiguration) |
There was a problem hiding this comment.
We can use the shorter init here
Suggested change
| let serviceGroupConfiguration = ServiceGroupConfiguration( | |
| services: [ServiceGroupConfiguration.ServiceConfiguration(service: memcacheConnection)], | |
| gracefulShutdownSignals: [], | |
| cancellationSignals: [], | |
| logger: self.logger | |
| ) | |
| // Initialize the service group | |
| let serviceGroup = ServiceGroup(configuration: serviceGroupConfiguration) | |
| // Initialize the service group | |
| let serviceGroup = ServiceGroup(services: memcacheConnection) |
FranzBusch
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address the need to integrate swift-service-lifecycle's
Serviceprotocol into ourMemcachedConnection.The incorporation of the Service protocol will ensure a unified and standardized lifecycle management for our Memcached service. This PR will close #36.
Motivation:
To adopt industry standards for service lifecycle management and improve the maintainability and operability of our
MemcachedConnection. Incorporating theServiceprotocol enhances the way we manage the startup and shutdown procedures of the service.Modifications:
Serviceprotocol inMemcachedConnection.ServiceGroupinitialization to includeMemcachedConnectionas aService.Results:
With the integration of the
Serviceprotocol,MemcachedConnectionnow benefits from standardized lifecycle management. This improves the reliability of the service and makes it easier to manage in production setups.