fix Buckets helpers to not throw fatal error #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
reviewed
Mar 3, 2021
MrLotU
approved these changes
Mar 10, 2021
There was a problem hiding this comment.
Thanks for the PR @avolokhov, and my excuses for taking a while to respond. LGTM 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @MrLotU. Thanks for considering this PR.
In my project I needed to create custom buckets and stumbled upon
Bucketshelpers throwing fatal errors all the time. Here's a fix for this.Checklist
Motivation and Context
Buckets static helpers are always throwing fatal errors.
Description
Bucketsstatic helpers are working now.