[clang] Allow parameterized isWeakImport based on an enclosing platform version
#10555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
approved these changes
Apr 28, 2025
|
@swift-ci test |
This was referenced Apr 28, 2025
Merged
|
@swift-ci test macOS platform |
…form version Similarly to 'CheckAvailability' and 'getAvailability', set 'Decl::isWeakImported' to allow querying using an external target platform version. In #7916 we have added support for configuring 'clang::CodeGenerator' with a differently-versioned target info, and this change adopts the code generator's target info in order to also determine weakly-imported linkage on declarations during code-gen. Before this change, they were relying on the 'ASTContext' to specify the target info, which may differ from code-gen's.
artemcm
force-pushed
the
ParameterizeWeakQueryForSwift-Stable
branch
from
e6a4b7d to
34b18ab
Compare
akyrtzi
approved these changes
Apr 29, 2025
|
@swift-ci test |
|
@swift-ci test macOS platform |
artemcm
added a commit
to artemcm/llvm-project
that referenced
this pull request
Jul 15, 2025
…computation A previous change (swiftlang#10555) added support for querying 'isWeakImported' to be parameterized on the enclosing target version to match 'CheckAvailability' and 'getAvailability'. We missed passing in this parameter in the Clang module code-gen when querying linkage for a global variable. This change adds the missing parameter and removes the default parameter from the query in order to avoid this kind of bug in the future. Resolves rdar://154677999
artemcm
added a commit
to artemcm/llvm-project
that referenced
this pull request
Jul 15, 2025
…computation A previous change (swiftlang#10555) added support for querying 'isWeakImported' to be parameterized on the enclosing target version to match 'CheckAvailability' and 'getAvailability'. We missed passing in this parameter in the Clang module code-gen when querying linkage for a global variable. This change adds the missing parameter and removes the default parameter from the query in order to avoid this kind of bug in the future. Resolves rdar://154677999
This was referenced Jul 15, 2025
Merged
artemcm
added a commit
that referenced
this pull request
Jul 17, 2025
…computation A previous change (#10555) added support for querying 'isWeakImported' to be parameterized on the enclosing target version to match 'CheckAvailability' and 'getAvailability'. We missed passing in this parameter in the Clang module code-gen when querying linkage for a global variable. This change adds the missing parameter and removes the default parameter from the query in order to avoid this kind of bug in the future. Resolves rdar://154677999
cyndyishida
pushed a commit
that referenced
this pull request
Jul 17, 2025
…computation A previous change (#10555) added support for querying 'isWeakImported' to be parameterized on the enclosing target version to match 'CheckAvailability' and 'getAvailability'. We missed passing in this parameter in the Clang module code-gen when querying linkage for a global variable. This change adds the missing parameter and removes the default parameter from the query in order to avoid this kind of bug in the future. Resolves rdar://154677999
AnthonyLatsis
pushed a commit
that referenced
this pull request
Jul 29, 2025
…computation A previous change (#10555) added support for querying 'isWeakImported' to be parameterized on the enclosing target version to match 'CheckAvailability' and 'getAvailability'. We missed passing in this parameter in the Clang module code-gen when querying linkage for a global variable. This change adds the missing parameter and removes the default parameter from the query in order to avoid this kind of bug in the future. Resolves rdar://154677999 (cherry picked from commit 69d0b90.) This change barely missed the `stable/21.x` cutoff; we only just realized we're missing it.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to
CheckAvailabilityandgetAvailability, setDecl::isWeakImportedto allow querying using an external target platform version.In #7916 we have added support for configuring
clang::CodeGeneratorwith a differently-versioned target info, and this change adopts the code generator's target info in order to also determine weakly-imported linkage on declarations during code-gen. Before this change, they were relying on theASTContextto specify the target info, which may differ from code-gen's.