[lldb/crashlog] Use raw strings to silence escape sequence warnings #11248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medismailben
force-pushed
the
stable/20240723
branch
from
8c9cc75 to
d6f6fe4
Compare
|
@swift-ci test |
medismailben
force-pushed
the
stable/20240723
branch
from
d6f6fe4 to
1d87cc7
Compare
This patch silences from escapte sequence warnings from the crashlog script that were mostly due to regular expression strings. This is addresses by using raw strings so the escape character isn't interpreted by python and gets passed straight to the regular expression engine. Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>
medismailben
force-pushed
the
stable/20240723
branch
from
1d87cc7 to
87f3b8f
Compare
|
@swift-ci test |
medismailben
changed the title
|
Is there a corresponding upstream patch? |
This has been changed as part of 24abf2c upstream but that patch affects the entire llvm-project directory not only lldb or crashlog related scripts. I tried cherry-picking it but I ran into some conflicts. Given that it would part of the rebranch anyway, I went ahead and cherry-picked only the changes related to crashlog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch silences from escape sequence warnings from the crashlog
script that were mostly due to regular expression strings.
This is addresses by using raw strings so the escape character isn't
interpreted by python and gets passed straight to the regular expression
engine.
Signed-off-by: Med Ismail Bennani ismail@bennani.ma