Reland "[C++ BoundsSafety] Fix false positives when pointer argument is a function call (#11046)" #11358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction call (#11046) When the pointer argument passing to a counted_by parameter is a function call returning a counted_by pointer, in order to check the compatibility with respect to their counted_by attributes, the compiler need to compare two expressions, which both have references to parameters that need substitutions. This commit is to generalize the compatibility checking to allow both comparands to be accompanied by substitution maps. rdar://155952016
|
The PR originally broke the build because it was slightly out of date with |
patrykstefanski
approved these changes
Sep 9, 2025
|
@swift-ci test llvm |
|
@swift-ci test |
ziqingluo-90
added a commit
that referenced
this pull request
Sep 10, 2025
…is a function call (#11046)" (#11358) When the pointer argument passing to a counted_by parameter is a function call returning a counted_by pointer, in order to check the compatibility with respect to their counted_by attributes, the compiler need to compare two expressions, which both have references to parameters that need substitutions. This commit is to generalize the compatibility checking to allow both comparands to be accompanied by substitution maps. rdar://155952016 (cherry picked from commit 46a1881)
ziqingluo-90
added a commit
that referenced
this pull request
Sep 11, 2025
…is a function call (#11046)" (#11358) (#11342) When the pointer argument passing to a counted_by parameter is a function call returning a counted_by pointer, in order to check the compatibility with respect to their counted_by attributes, the compiler need to compare two expressions, which both have references to parameters that need substitutions. This commit is to generalize the compatibility checking to allow both comparands to be accompanied by substitution maps. rdar://155952016 (cherry picked from commit 46a1881)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the pointer argument passing to a counted_by parameter is a
function call returning a counted_by pointer, in order to check the
compatibility with respect to their counted_by attributes, the
compiler need to compare two expressions, which both have references
to parameters that need substitutions.
This commit is to generalize the compatibility checking to allow both
comparands to be accompanied by substitution maps.
rdar://155952016