Skip to content

🍒 [lldb][windows] use Windows APIs to print to the console (#156469) #11373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2025
Merged

🍒 [lldb][windows] use Windows APIs to print to the console (#156469) #11373

merged 1 commit into from
Sep 11, 2025

Conversation

charles-zablit
Copy link

@charles-zablit
[lldb][windows] use Windows APIs to print to the console (llvm#156469)
b18ea86 
This is a relanding of llvm#149493.
The tests were failing because we were interpreting a proper file
descriptor as a console file descriptor.

This patch uses the Windows APIs to print to the Windows Console,
through `llvm::raw_fd_ostream`.

This fixes a rendering issue where the characters defined in
`DiagnosticsRendering.cpp` ("╰" for instance) are not rendered properly
on Windows out of the box, because the default codepage is not `utf-8`.

This solution is based on [this patch
downstream](https://github.com/swiftlang/swift/pull/40632/files#diff-e948e4bd7a601e3ca82d596058ccb39326459a4751470eec4d393adeaf516977R37-R38).

rdar://156064500
(cherry picked from commit f444576)
@charles-zablit charles-zablit merged commit c440bec into swiftlang:stable/21.x Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JDevlieghere JDevlieghere Awaiting requested review from JDevlieghere JDevlieghere is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charles-zablit