[lldb] Fix ThreadPlanStepOut when returning from trampolines #11427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
When ThreadPlanStepOut decides to step out of a frame, it enqueues a subplan to do so. However, when that plan is complete, ThreadPlanStepOut::ShouldStop forget to set the `done` boolean properly. This was exposed by a recent patch in LLVM: https://github.com/llvm/llvm-project/pull/126838/files
felipepiovezan
force-pushed
the
felipe/stepout_fixes
branch
from
4d129ba to
9fb9567
Compare
|
@swift-ci test |
unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ThreadPlanStepOut decides to step out of a frame, it enqueues a subplan to do so. However, when that plan is complete, ThreadPlanStepOut::ShouldStop forget to set the
doneboolean properly. This was exposed by a recent patch in LLVM:https://github.com/llvm/llvm-project/pull/126838/files