Skip to content

Cp/r160698393 fix yaml2macho core path #11569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2025
Merged

Cp/r160698393 fix yaml2macho core path #11569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
388631e
[lldb][yaml2macho-core] Set binary path for tests differently
jasonmolenda Oct 3, 2025
0fb3778
[lldb] remove test skips from yaml2macho-core tests
jasonmolenda Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lldb/packages/Python/lldbsuite/test/dotest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,9 +279,6 @@ def parseOptionsAndInitTestdirs():
configuration.llvm_tools_dir = args.llvm_tools_dir
configuration.filecheck = shutil.which("FileCheck", path=args.llvm_tools_dir)
configuration.yaml2obj = shutil.which("yaml2obj", path=args.llvm_tools_dir)
configuration.yaml2macho_core = shutil.which(
"yaml2macho-core", path=args.llvm_tools_dir
)

if not configuration.get_filecheck_path():
logging.warning("No valid FileCheck executable; some tests may fail...")
Expand Down Expand Up @@ -561,6 +558,8 @@ def setupSysPath():
if is_exe(lldbDAPExec):
os.environ["LLDBDAP_EXEC"] = lldbDAPExec

configuration.yaml2macho_core = shutil.which("yaml2macho-core", path=lldbDir)

lldbPythonDir = None # The directory that contains 'lldb/__init__.py'

# If our lldb supports the -P option, use it to find the python path:
Expand Down
1 change: 0 additions & 1 deletion lldb/test/API/functionalities/unwind/cortex-m-exception/TestCortexMExceptionUnwind.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
from lldbsuite.test.lldbtest import *
from lldbsuite.test import lldbutil

@skipIf(bugnumber = "rdar://160698191")
class TestCortexMExceptionUnwind(TestBase):
NO_DEBUG_INFO_TESTCASE = True

Expand Down
1 change: 0 additions & 1 deletion lldb/test/API/macosx/arm-corefile-regctx/TestArmMachoCorefileRegctx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from lldbsuite.test.lldbtest import *
from lldbsuite.test import lldbutil

@skipIf(bugnumber = "rdar://160698553")
class TestArmMachoCorefileRegctx(TestBase):
NO_DEBUG_INFO_TESTCASE = True

Expand Down
1 change: 0 additions & 1 deletion lldb/test/API/macosx/riscv32-corefile/TestRV32MachOCorefile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from lldbsuite.test.lldbtest import *
from lldbsuite.test import lldbutil

@skipIf(bugnumber = "rdar://160698393")
class TestRV32MachOCorefile(TestBase):
NO_DEBUG_INFO_TESTCASE = True

Expand Down