Revert "[clang][modules] Lazily load by name lookups in module maps (#132853)" #11600
+136
−457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lvm#132853)" This is causing a slowdown in SourceKit completion requests. The slowdown is caused by the call to `SourceManager::translateFile` that was added to avoid allocating separate source location space for each module map in each `CompilerInstance`. rdar://162196108 This reverts commit 32fb8c5.
|
@swift-ci please test |
cyndyishida
approved these changes
Oct 8, 2025
|
@swift-ci please test macos |
|
@swift-ci please test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing a slowdown in SourceKit completion requests.
The slowdown is caused by the call to
SourceManager::translateFilethat was added to avoid allocating separate source location space for each module map in eachCompilerInstance.rdar://162196108
This reverts commit 32fb8c5.