Skip to content

Conversation

hjyamauchi
Copy link

@hjyamauchi
Copy link
Author

@swift-ci please test

@hjyamauchi
Copy link
Author

@swift-ci please test Windows platform

@hjyamauchi hjyamauchi marked this pull request as ready for review October 14, 2025 16:00
Copy link

@cachemeifyoucan cachemeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it happen on next branch?

This change will not apply to next since VFS layer is free of CAS representation now. If next is fine, I can cherry-pick over the CAS changes from next branch. Otherwise, we need a different fix.

@hjyamauchi
Copy link
Author

Yes, this crashes on the next branch too.

I see that after #11235, the fix doesn't work.

Do you have a suggestion how we may fix this on next? I didn't come up with a good way there because FileWithFixedStatus isn't visible outside VirtualFileSystem.cpp and the dyn_cast<CASBackedFile> checks do not seem to straightforwardly fit with the FileWithFixedStatus case.

@cachemeifyoucan
Copy link

Yes, this crashes on the next branch too.

I see that after #11235, the fix doesn't work.

Do you have a suggestion how we may fix this on next? I didn't come up with a good way there because FileWithFixedStatus isn't visible outside VirtualFileSystem.cpp and the dyn_cast<CASBackedFile> checks do not seem to straightforwardly fit with the FileWithFixedStatus case.

Let me try your test case on next branch.

@cachemeifyoucan
Copy link

#11629

@hjyamauchi
Copy link
Author

#11629

Great. What do we do for the stable/21.x branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants